Push code review advice from @sigmavirus24

This commit is contained in:
Cory Benfield
2015-12-19 08:44:21 +00:00
parent 589f13ca9d
commit 6e0649d9f8
+5 -4
View File
@@ -115,11 +115,12 @@ def get_netrc_auth(url, raise_errors=False):
ri = urlparse(url)
# Strip port numbers from netloc
# Strip port numbers from netloc. This weird `if...encode`` dance is
# used for Python 3.2, which doesn't support unicode literals.
splitstr = b':'
if isinstance(url, str):
host = ri.netloc.split(u':')[0]
else:
host = ri.netloc.split(b':')[0]
splitstr = splitstr.decode('ascii')
host = ri.netloc.split(splitstr)[0]
try:
_netrc = netrc(netrc_path).authenticators(host)