Michael Komitee
df5dcb8a7d
New tests fail on python 3.x because read() returns bytes and the test checks for strings
2013-02-13 22:42:56 -05:00
Michael Komitee
69ba64380b
Adding test to ensure options like stream function with authentication
...
This test demonstrates the reason why we need to pass kwargs to hooks. Without
it, features like stream cannot work with authentication.
2013-02-13 21:28:32 -05:00
Michael Komitee
d0285fac42
Use user supplied options when resending authenticated requests
...
Hooks sometimes have to send requests (e.g. when responding to a 401 during
authentication).
All keyword arguments should be passed along when hooks are dispatched so that
if a user wanted to use a timeout, stream, specify a cert location with the
verify flag, etc, their specification can be followed.
2013-02-13 19:11:38 -05:00
Kenneth Reitz
f73bda06e9
Merge pull request #1185 from sigmavirus24/fix_hook_dispatching
...
Dispatch hooks before following redirects
2013-02-13 02:13:31 -08:00
Ian Cordasco
4dfd6f3fc1
Dispatch hooks before following redirects
...
Fixes #1183
2013-02-12 23:00:06 -05:00
Kenneth Reitz
cdec20af65
Merge pull request #1181 from denis-ryzhkov/master
...
Fix of UnicodeDecodeError on unicode header name that can be converted to ascii.
2013-02-12 08:43:02 -08:00
Kenneth Reitz
09a7251245
Merge pull request #1184 from piotr-dobrogost/numeric_codes
...
small cleanup of redirect codes
2013-02-12 00:27:05 -08:00
Denis Ryzhkov
56f4b7ca68
Deleted is_py2 check from unicode_header_name fix thanks to Lukasa.
2013-02-12 09:51:46 +03:00
Piotr Dobrogost
4c8d1b9a7d
removed no longer used redirect codes from models
...
added numeric values of redirect codes in comments
2013-02-11 23:07:12 +01:00
Denis Ryzhkov
6da7e22a4a
Fix of UnicodeDecodeError on unicode header name that can be converted to ascii.
2013-02-11 15:37:58 +03:00
Kenneth Reitz
5d9fcc711b
Merge pull request #1180 from sigmavirus24/master
...
Fix Session level Cookie Handling
2013-02-10 16:43:21 -08:00
Ian Cordasco
2e31696156
Test and perfection for cookie handling.
...
I also fixed up some of the RequestsCookieJar methods so using
jar.update(other_jar) works without a problem. This cleans up some of the code
in sessions and the resolve_redirects method.
2013-02-10 19:36:36 -05:00
Ian Cordasco
0fb13e0b6c
And tests
2013-02-10 17:49:49 -05:00
Kenneth Reitz
1da1490bcd
urllib3 update
...
#1053
2013-02-10 17:43:58 -05:00
Ian Cordasco
9cdc8325ae
Fix Setting a cookie on redirect
2013-02-10 17:43:37 -05:00
Kenneth Reitz
12d66cfc41
Merge pull request #1173 from sigmavirus24/use_send_in_resolve_redirects
...
Use send in resolve redirects
2013-02-10 14:21:13 -08:00
Ian Cordasco
9c8660dbb6
Resolve @piotr-dobrogost's concerns
...
Piotr had good objections to my not re-sending the body of the request on 307.
2013-02-10 17:14:45 -05:00
Ian Cordasco
e7bc9bf1b2
Preserve the original request.
...
Let's make a copy to preserve it.
2013-02-10 17:11:16 -05:00
Ian Cordasco
e2ad0d0fe8
We shouldn't be sending the data on redirect.
...
As such, we should remove the body from the old request as well as the
Content-Length header.
2013-02-10 17:11:16 -05:00
Ian Cordasco
3299771e34
Fix the potential issue mentioned in #1151
...
See: https://github.com/kennethreitz/requests/pull/1151#issuecomment-12905796
This is solved by just reusing the PreparedRequest from the last request.
2013-02-10 17:11:16 -05:00
Kenneth Reitz
f2be5fae27
Merge pull request #1161 from sigmavirus24/fix1159
...
If Content-Length is already set, don't override
2013-02-10 14:07:08 -08:00
Kenneth Reitz
90cd37fda0
Merge pull request #1119 from Lukasa/diags
...
Better diagnostics when trying to send unprepared request
2013-02-10 14:06:38 -08:00
Cory Benfield
b0657cf163
Guard against users sending unprepared requests.
2013-02-10 06:13:02 +00:00
Kenneth Reitz
03f6908fe9
Merge pull request #1162 from Lukasa/proxy_auth
...
Proxy Authorization Headers
2013-02-06 13:05:04 -08:00
Kenneth Reitz
c68f928254
Merge pull request #1168 from Lukasa/freeze
...
Feature freeze.
2013-02-06 11:53:55 -08:00
Cory Benfield
ff954e16f1
Feature freeze.
2013-02-06 19:01:24 +00:00
Cory Benfield
d437c338d0
Add Proxy-Auth header when proxies have credentials.
2013-02-06 18:40:35 +00:00
Kenneth Reitz
9fc7059140
Merge pull request #1151 from sigmavirus24/fix1133
...
Move redirect handling from Session.request to Session.send
2013-02-05 11:42:51 -08:00
Ian Cordasco
544d08d0f6
If Content-Length is already set, don't override
...
Re: #1159
2013-02-01 11:58:23 -05:00
Kenneth Reitz
ae55676a50
Merge pull request #1158 from yehudasa/master
...
Fix check that breaks handling of 303 response in some cases (v2)
2013-02-01 07:30:47 -08:00
Yehuda Sadeh
b07c1ebd85
Fix POST 303 redirect resonse handling
...
This fixes issue #1156 .
Signed-off-by: Yehuda Sadeh <yehuda@inktank.com >
2013-01-31 11:23:09 -08:00
Kenneth Reitz
113b67c069
moar
2013-01-31 14:35:42 +00:00
Kenneth Reitz
12246afab8
HMG
2013-01-31 13:20:14 +00:00
Kenneth Reitz
85da715f40
Merge pull request #1153 from cbare/master
...
use only base filename in multipart file upload
2013-01-30 15:56:21 -08:00
Kenneth Reitz
b554b0c1cb
Merge pull request #1152 from ekatsah/patch-1
...
Update docs/user/advanced.rst
2013-01-30 15:54:20 -08:00
Christopher Bare
9ff8cbe5fb
shorten filename by os.path.basename in guess_filename(obj)
2013-01-30 15:33:43 -08:00
ekatsah
79727abb32
Update docs/user/advanced.rst
...
Rephrasing a line in the docs, add explicite mention of "client side certificate" (for indexing and clarity)
2013-01-30 21:22:24 +01:00
Ian Cordasco
ba485913b6
Thanks to @maxcountryman for the code review
2013-01-30 10:58:32 -05:00
Ian Cordasco
a95bfd3032
Fix the elapsed test and #1133
2013-01-29 23:50:37 -05:00
Kenneth Reitz
207a2744aa
Merge pull request #1143 from Lukasa/master
...
Response as iterator
2013-01-28 20:52:17 -08:00
Cory Benfield
95084c9ca8
Fix test for Py3.
2013-01-28 18:35:41 +00:00
Cory Benfield
2f7923bc05
More useful docstring.
2013-01-28 18:35:41 +00:00
Cory Benfield
2ac3913733
Make Response objects iterable.
2013-01-28 18:35:41 +00:00
Kenneth Reitz
231e343a3b
Merge pull request #1148 from sigmavirus24/timing_switch
...
Move the timing work to Session.send
2013-01-28 09:40:10 -08:00
Ian Cordasco
c8ad4f0b73
Move the timing work to Session.send
...
per @kennethreitz 's request
2013-01-28 11:53:02 -05:00
Kenneth Reitz
25545b393b
Merge pull request #1146 from oczkers/master
...
It`s more pep8 now
2013-01-27 19:11:15 -08:00
Kenneth Reitz
dfa89e299a
Merge pull request #1138 from clee/master
...
Time each request
2013-01-27 19:10:16 -08:00
Chris Lee
318300848f
Use timedelta and change attribute name back to elapsed
2013-01-27 19:07:48 -08:00
Chris Lee
d4aaef1e9a
Time how long each request takes
...
Stored as attribute Response.time_taken
2013-01-27 19:06:50 -08:00
oczkers
40a060cf57
it`s more pep8 now
2013-01-27 02:04:12 +01:00