kennethreitz/tablib
1
0
Fork 0
mirror of https://github.com/kennethreitz/tablib.git synced 2026-06-05 23:10:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #189 from tsroten/issue_184

Browse Source 
Fixes Row slicing. Fixes #184.
This commit is contained in:
Iuri de Silvio
2015-04-05 20:05:31 -03:00
parent 2fbda0f43d 541fba6786
commit 24657520e9
2 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tablib/core.py
+1 -1
View File
@@ -45,7 +45,7 @@ class Row(object):
return repr(self._row)
def __getslice__(self, i, j):
return self._row[i,j]
return self._row[i:j]
def __getitem__(self, i):
return self._row[i]
test_tablib.py
+13
View File
@@ -8,6 +8,7 @@ import sys
import os
import tablib
from tablib.compat import markup, unicode, is_py3
from tablib.core import Row
@@ -206,6 +207,18 @@ class TablibTestCase(unittest.TestCase):
self.assertEqual(self.founders[2:], [self.tom])
def test_row_slicing(self):
"""Verify Row's __getslice__ method. Issue #184."""
john = Row(self.john)
self.assertEqual(john[:], list(self.john[:]))
self.assertEqual(john[0:], list(self.john[0:]))
self.assertEqual(john[:2], list(self.john[:2]))
self.assertEqual(john[0:2], list(self.john[0:2]))
self.assertEqual(john[0:-1], list(self.john[0:-1]))
def test_delete(self):
"""Verify deleting from dataset works."""