Databook.add_sheet accepts Dataset subclasses

This commit is contained in:
Kuba Janoszek
2012-03-13 00:05:24 +01:00
parent c0a3c3ea1e
commit 8e83734985
2 changed files with 16 additions and 1 deletions
+1 -1
View File
@@ -955,7 +955,7 @@ class Databook(object):
def add_sheet(self, dataset):
"""Adds given :class:`Dataset` to the :class:`Databook`."""
if type(dataset) is Dataset:
if isinstance(dataset, Dataset):
self._datasets.append(dataset)
else:
raise InvalidDatasetType
+15
View File
@@ -669,5 +669,20 @@ Old |Man |100500
)
def test_databook_add_sheet_accepts_dataset_subclasses(self):
class DatasetSubclass(tablib.Dataset):
pass
# just checking if subclass of tablib.Dataset can be added to Databook
dataset = DatasetSubclass()
dataset.append(self.john)
dataset.append(self.tom)
try:
book.add_sheet(dataset)
except tablib.InvalidDatasetType:
self.fail("Subclass of tablib.Dataset should be accepted by Databook.add_sheet")
if __name__ == '__main__':
unittest.main()