mirror of
https://github.com/not-kennethreitz/convore.json.git
synced 2026-06-05 23:20:19 +00:00
Kenneth Reitz
1 line
2.4 KiB
JSON
1 line
2.4 KiB
JSON
[{"user_id": 1548, "stars": [], "topic_id": 8083, "date_created": 1298393821.4443531, "message": "Anybody see any problems with this function? http://pastebin.com/c657LBLp", "group_id": 160, "id": 180290}, {"user_id": 8327, "stars": [], "topic_id": 8083, "date_created": 1298398061.62517, "message": "For the most part, seems to work ok for me; few optimisations: times == count could probably be >= and += 1 can be shortened to ++ http://pastebin.com/RxRxWPar", "group_id": 160, "id": 180914}, {"user_id": 1548, "stars": [], "topic_id": 8083, "date_created": 1298406281.318337, "message": "Thanks for the input. Agree with the ++ bit. However your modified version with <= will clear the interval timer on the first go. I think you probably meant >=. I used == because count should never be set by anything else and makes checking for > unnecessary.\n\nThis is one of those bits of code that after I've written I look at and can't help but thinking: \"surely that can't be it?! I must have missed something...\"", "group_id": 160, "id": 182360}, {"user_id": 8327, "stars": [], "topic_id": 8083, "date_created": 1298408585.806267, "message": "You're quite right, daftness on my part, I read it a few times and still manged to trip over the difference between count and times, from a readability standpoint perhaps limit might be better", "group_id": 160, "id": 182625}, {"user_id": 8327, "stars": [], "topic_id": 8083, "date_created": 1298408635.5962801, "message": "It irks me also when stuff seems trivial to the point you can't help wondering if you've overlooked something; but in this case it seems to do exactly what it says on the can", "group_id": 160, "id": 182628}, {"user_id": 1548, "stars": [], "topic_id": 8083, "date_created": 1298473430.477186, "message": "Thanks again. You're right, limit would be better. Sometimes I just hit a blank wall with my variable naming... :-p", "group_id": 160, "id": 187919}, {"user_id": 1151, "stars": [], "topic_id": 8083, "date_created": 1298516863.0988989, "message": "Might not be a huge deal but I was always under the impression that setTimeout is preferable to setInterval http://stackoverflow.com/questions/729921/settimeout-or-setinterval/731625#731625", "group_id": 160, "id": 194986}, {"user_id": 8327, "stars": [], "topic_id": 8083, "date_created": 1298572587.4040749, "message": "Guess it depends if you want the next fire to be a set time from the previous start, or previous end", "group_id": 160, "id": 200110}] |