Although it is true that the remote can be chosen arbitrarily through the popup menus
we still need to have a specific local branch. All branches is not a specific branch.
Of course we could do away with determining the current local branch through what's
selected in the branch popup menu and instead focus on what the appropriate controller's
current selection is.
- Complete the action methods for fetch and rebase.
- Add a more generic and re-usable method for updating the popup toolbar items.
- Comment out updatePushMenuWithRemotes: and updatePullMenuWithRemotes: as those have been
superseded by updatePopUpToolbarItemMenu:remotes:action:title:
Update toolbar item sizes to work against the visual inconsistency where the items
where off by 1 pixel causing toolbar jumps between history and commit view.
A deletion execution dialog should block the UI until it's complete if there could
potentionally be state change occurring which has different outcome for pre-deletion
or post-deletion finite state.
A middle ground solution would be to use a modal sheet attached to a specific document
which then only blocks this particular document.
If "All branches" or "Local branches" is selected, the buttons will be disabled.
Actions from the context menu continue to work as they implicitly set the target branch
through the identity of the clicked label patch.
Any other branch will re-enable the buttons.
As some Apple employees continue to advocate: Using dot notation for anything else than
documented (!) synthesized properties and calling non-behavioural messages can be dangerous.
Methods that look like setters/getters but aren't connected to a documented property may
introduce private state change inside the class which can further bring all sorts of subtle
and hard to debug problems. The Objective-C 2.0 Language Guide now also mentions this.
When right-clicking on a ref label, if the ref has a default remote configured ,
a new greyed out menu entry with the remote's name is put above all other menu
entries and separated by a menu item separator.
Mind you, these buttons cannot operate on the clicked branch like the context menu.
Instead they always operate on the currently active branch (or its default remote).
Update inherent height of branch popup button to the max height to get rid of the 1px movement between view change.
Remove another unused localization.
André Berg