Commit Graph

834 Commits

Author SHA1 Message Date
André Berg 2c6fd97b5c Cosmetic: Move showMessageSheet convenience method to the proper pragma mark section. 2009-11-08 16:30:18 +01:00
André Berg 1ade0f0620 Remove completely wrong TODO comment.
A deletion execution dialog should block the UI until it's complete if there could
potentionally be state change occurring which has different outcome for pre-deletion
or post-deletion finite state.

A middle ground solution would be to use a modal sheet attached to a specific document
which then only blocks this particular document.
2009-11-08 16:28:50 +01:00
André Berg 1a7b4cb4c7 Update branch menu after deletion of a branch. 2009-11-08 16:26:07 +01:00
André Berg 4cdf6348ca Replace pre-10.6 workaround with public - [NSSavePanel setShowsHiddenFiles:] method. 2009-11-08 16:24:04 +01:00
André Berg 22ba33f575 Disable/re-enable Push, Pull and Rebase buttons depending on selected branch validity.
If "All branches" or "Local branches" is selected, the buttons will be disabled. 
Actions from the context menu continue to work as they implicitly set the target branch
through the identity of the clicked label patch.
Any other branch will re-enable the buttons.
2009-11-08 16:22:53 +01:00
André Berg b6d6e0d5c2 Bug fix: Correct dot notation misuse.
As some Apple employees continue to advocate: Using dot notation for anything else than
documented (!) synthesized properties and calling non-behavioural messages can be dangerous.
Methods that look like setters/getters but aren't connected to a documented property may
introduce private state change inside the class which can further bring all sorts of subtle
and hard to debug problems. The Objective-C 2.0 Language Guide now also mentions this.
2009-11-08 16:20:08 +01:00
André Berg 1551084b16 Update context menu to include remote target and other dynamic title changes.
When right-clicking on a ref label, if the ref has a default remote configured , 
a new greyed out menu entry with the remote's name is put above all other menu
entries and separated by a menu item separator.
2009-11-07 04:25:12 +01:00
André Berg f1fcb18a92 Improve error and tooltip descriptions. 2009-11-07 04:20:24 +01:00
André Berg 4c4203a7ce Update PBGitErrors to include some error messages dealing with missing remote tracking branches.
This is especially useful for the new button functionality.
2009-11-07 01:02:22 +01:00
André Berg d04c639730 Update tooltips for Push, Pull and Rebase buttons to better reflect what will happen. 2009-11-07 01:00:39 +01:00
André Berg 2cc3c730d6 Filter debug log output by getenv adressable Xcode environment vars. 2009-11-04 19:39:50 +01:00
André Berg 0f50cd6673 Bug fix: reconnect the search field predicates so the field works again. 2009-11-04 19:39:05 +01:00
André Berg 93a027cccd Bug fix: Make new buttons actually work.
Mind you, these buttons cannot operate on the clicked branch like the context menu. 
Instead they always operate on the currently active branch (or its default remote).
2009-11-03 04:38:30 +01:00
André Berg 421d6fd9ed Bug fix: Wrong usage of dot notation. 2009-11-03 04:37:03 +01:00
André Berg b76f7551ac Safety measure: Replace unneeded stringWithFormat with stringWithString because the format string is the content string. 2009-11-01 00:51:13 +01:00
André Berg 7892ac4612 Update toolbars to incorporate the new buttons.
Update inherent height of branch popup button to the max height to get rid of the 1px movement between view change.
Remove another unused localization.
2009-11-01 00:46:31 +01:00
André Berg 4396081c07 Add new PNG templates for Pull, Push, Rebase and Clone. 2009-11-01 00:39:57 +01:00
André Berg 0d42c592cf Override openDocumentWithContentsOfURL:... to provide sanity checks for the case when a recent items entry no longer has a git repo associated with it. GitX fails gracefully and displays a recovery suggestion. 2009-11-01 00:38:41 +01:00
André Berg 7c1b9d9961 Add pullButton: IBAction. 2009-11-01 00:29:07 +01:00
André Berg d5688dbfaf Exert other options before falling back to PBGitRepository's global state. 2009-11-01 00:26:44 +01:00
André Berg 1fed883b98 Loading message restricted to DEBUG_BUILD. 2009-11-01 00:25:34 +01:00
André Berg 2a6f59b652 Synthesize repositoryPath for external access. 2009-11-01 00:23:33 +01:00
André Berg 5be745177c Add sanity check to PBEasyPipe that checks if a working dir really is a folder. 2009-11-01 00:19:25 +01:00
André Berg fb0fbff6d2 Combine scatterred error domains and codes into one central file. 2009-11-01 00:18:38 +01:00
André Berg 7d19e1c162 Disable 'Save' menu item if no document is open. 2009-11-01 00:15:39 +01:00
André Berg d4a7df12a3 Remove superfluous resources and underutilized localizations. 2009-11-01 00:09:34 +01:00
André Berg e80bcefa60 Update menu entry title to better match rest: 'Detailed View' -> 'Detail View'. 2009-10-26 23:43:07 +01:00
André Berg b7ec771771 Add alternative icons for Rebase, Push and Pull. 2009-10-26 23:39:55 +01:00
Morgan Schweers 3c113a3dd0 Update the submodule to point to the actual libgit2 repository. 2009-10-26 16:33:59 +01:00
Morgan Schweers 7eb3616f3f Disable toolbar entries when they are processing, as at least some minimal feedback for the user. I still think it needs a progress bar dialog, or something. 2009-10-26 16:31:35 +01:00
Morgan Schweers 5b0051e13c Rudimentary clone capability from the File menu.
No progress display, so it's UX sucks, but it works.

Need to add a progress display, so the user knows it's not just lost in the weeds.  Either a neutral 'working' progress bar, or (optimally) some cool thing that feeds off the pipe and fills a text display.
2009-10-26 16:31:23 +01:00
André Berg 2b0000ca23 Add menu and toolbar changes from cyberfox 2009-10-26 16:26:52 +01:00
Morgan Schweers b580c03795 DRY up the menu adding code
Add rebase and pull menu items
Get upstream name more git-accurately for upstream operations
2009-10-26 16:16:04 +01:00
Morgan Schweers 4b74a3f92a Disable the push menu item for branches which don't have a remote. 2009-10-26 16:15:50 +01:00
Morgan Schweers cdc4f5208b Add a menu item and an action for pushing a repo up. 2009-10-26 16:15:35 +01:00
Morgan Schweers fa929eb7c9 Use the libgit2 allocfmt method, instead of hacking it by hand. 2009-10-26 15:54:31 +01:00
Morgan Schweers 611687e7c5 Use the newer libgit2 method for extracting a hex digest from an object id. 2009-10-26 15:52:47 +01:00
André Berg a2ebc4a4fd Add stderr to PBEasyPipe output for helpful messages to Console. 2009-10-26 15:34:51 +01:00
André Berg fed2cc4806 Update checkbox buttons to non scaling to get rid of the XIB compiler warnings. 2009-10-24 21:45:04 +02:00
André Berg 75abf03766 Add 10.6 delegate protocols to silence compiler warnings.
The net result is the same as of 10.5 when those were informal categories on NSObject.
2009-10-24 21:44:05 +02:00
André Berg 0df2d3f299 Merge branch 'fqueue' into devel 2009-10-24 20:30:38 +02:00
André Berg 7bf4ed5c38 Bug fix: Change notification to avoid display freezes when the QuickLook panel hides during the repository window's auto refresh. 2009-10-24 20:30:19 +02:00
André Berg 286b727b50 Merge branch 'ab/fqueue_stage' into devel 2009-10-24 11:25:39 +02:00
André Berg c76c922414 Add missing changes for commit 11cc30 from rastersize's fork 2009-10-24 11:23:38 +02:00
André Berg 350be101d3 Merge branch 'ab/fqueue_stage' into devel 2009-10-24 09:04:37 +02:00
André Berg fcbe01b091 Xcode build name again. Just ignore it. 2009-10-24 09:00:34 +02:00
Aron Cedercrantz 11cc30bc36 Add on window selection refresh.
The changes in PBViewController is only there to
supress a compiler warning.
2009-10-24 14:57:06 +08:00
Yoshimasa Niwa 73fcb78cb4 FIX: bug 2009-10-24 14:56:42 +08:00
Yoshimasa Niwa 003977dad9 FIX: memory leak(delete will not be called) and graph glitch
* When we are using subtree merge on git repository,
  GitX may show the slipped graph line.
* Behind this glitch, GitX may leak the PBGitLane object.
2009-10-24 14:56:29 +08:00
Steven Michalske c13474e7a3 Added weeks to the strings of time. 2009-10-24 14:55:54 +08:00